AnalogRX Power "Auto" -batch 2 goggle#312
Merged
ligenxxxx merged 7 commits intohd-zero:mainfrom Jul 31, 2023
pitts-mo:patch-1
Merged
AnalogRX Power "Auto" -batch 2 goggle#312ligenxxxx merged 7 commits intohd-zero:mainfrom pitts-mo:patch-1
ligenxxxx merged 7 commits intohd-zero:mainfrom
pitts-mo:patch-1
Conversation
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
Contributor
Author
|
Ok, I have rebuilt from this PR and Auto AnalogRX Power function appears to resolve issue #230 . Suggest running HDZGOGGLE from SD card and heavily test this is working as you expected before operating your remote equipment . |
format cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the AnalogRX Power setting "Off" with "Auto" and adds a function to track/set analog module bay power only on state change. Currently this will beep on every commanded state change except initiation of Go Sleep! function.
WARNING!
This should read like a very familiar hangup with implementing a physical power switch. Adding this feature is important. However, creating any system to change the power state of a critical item introduces potential risk. So, This needs to be heavily tested prior to usage with remote equipment and commit of this PR into master.
Known issues while AnalogRX Power is set to "On":
-none this is similar to batch 1 goggle behavior
Known issues while AnalogRX Power is set to "Auto":
-Source page will report Expansion Module: Disconnected when Expansion Module is not the currently selected source. Just select Expansion Module to use it anyway.
-when using ELRS backpack without a Binding Phrase (traditional binding) in your analog bay you will loose your backpack binding by switching in/out of Expansion Module source within 30 seconds three times.
Potential future enhancement:
-Add "Off" back in as a distinct setting (On, Auto, Off).
-disable beep on state change.
-add priority settings for debug beeps.