Skip to content

AnalogRX Power "Auto" -batch 2 goggle#312

Merged
ligenxxxx merged 7 commits intohd-zero:mainfrom
pitts-mo:patch-1
Jul 31, 2023
Merged

AnalogRX Power "Auto" -batch 2 goggle#312
ligenxxxx merged 7 commits intohd-zero:mainfrom
pitts-mo:patch-1

Conversation

@pitts-mo
Copy link
Contributor

@pitts-mo pitts-mo commented Jul 8, 2023

This PR replaces the AnalogRX Power setting "Off" with "Auto" and adds a function to track/set analog module bay power only on state change. Currently this will beep on every commanded state change except initiation of Go Sleep! function.

WARNING!
This should read like a very familiar hangup with implementing a physical power switch. Adding this feature is important. However, creating any system to change the power state of a critical item introduces potential risk. So, This needs to be heavily tested prior to usage with remote equipment and commit of this PR into master.

Known issues while AnalogRX Power is set to "On":
-none this is similar to batch 1 goggle behavior

Known issues while AnalogRX Power is set to "Auto":
-Source page will report Expansion Module: Disconnected when Expansion Module is not the currently selected source. Just select Expansion Module to use it anyway.
-when using ELRS backpack without a Binding Phrase (traditional binding) in your analog bay you will loose your backpack binding by switching in/out of Expansion Module source within 30 seconds three times.

Potential future enhancement:
-Add "Off" back in as a distinct setting (On, Auto, Off).
-disable beep on state change.
-add priority settings for debug beeps.

pitts-mo added 6 commits July 8, 2023 08:58
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
AnalogRX Power "Auto" -batch 2 google
@pitts-mo
Copy link
Contributor Author

pitts-mo commented Jul 8, 2023

Ok, I have rebuilt from this PR and Auto AnalogRX Power function appears to resolve issue #230 .

Suggest running HDZGOGGLE from SD card and heavily test this is working as you expected before operating your remote equipment .
-p

@pitts-mo pitts-mo changed the title AnalogRX Power "Auto" -batch 2 google AnalogRX Power "Auto" -batch 2 goggle Jul 9, 2023
format cleanup
@ligenxxxx ligenxxxx merged commit ab9d7c1 into hd-zero:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants