Skip to content

Add cpp guards and convert to #pragma once#366

Merged
ligenxxxx merged 2 commits intohd-zero:mainfrom
Master92:externC
Nov 22, 2023
Merged

Add cpp guards and convert to #pragma once#366
ligenxxxx merged 2 commits intohd-zero:mainfrom
Master92:externC

Conversation

@Master92
Copy link
Contributor

@Master92 Master92 commented Nov 6, 2023

This is only a cosmetic change and shouldn't make the software behave any different to as it was before. Binary diff says:

$ diff -s HDZGOGGLE_main HDZGOGGLE_new
Files HDZGOGGLE_main and HDZGOGGLE_new are identical

The only reason for this PR is that you effectively can't write any cpp code right now without considering which include has to declared extern "C" and which doesn't.

@SumolX
Copy link
Contributor

SumolX commented Nov 8, 2023

I would also recommend that we also standardize the include guard to use #pragma once for all files.

@Master92
Copy link
Contributor Author

Master92 commented Nov 8, 2023

I would also recommend that we also standardize the include guard to use #pragma once for all files.

Totally agreed! I'll update this PR in the next few hours 👍

@Master92 Master92 changed the title Add cpp guard to all c headers Add cpp guards and convert to #pragma once Nov 8, 2023
@ligenxxxx
Copy link
Member

Please solve the conflicts.

@Master92
Copy link
Contributor Author

Force-pushed due to rebase to current main HEAD resolving the merge-conflict.

@ligenxxxx ligenxxxx merged commit 8b560fd into hd-zero:main Nov 22, 2023
@Master92 Master92 deleted the externC branch November 30, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants