Add cpp guards and convert to #pragma once#366
Merged
ligenxxxx merged 2 commits intohd-zero:mainfrom Nov 22, 2023
Merged
Conversation
Contributor
|
I would also recommend that we also standardize the include guard to use #pragma once for all files. |
Contributor
Author
Totally agreed! I'll update this PR in the next few hours 👍 |
Member
|
Please solve the conflicts. |
Contributor
Author
|
Force-pushed due to rebase to current main HEAD resolving the merge-conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a cosmetic change and shouldn't make the software behave any different to as it was before. Binary diff says:
The only reason for this PR is that you effectively can't write any cpp code right now without considering which include has to declared
extern "C"and which doesn't.