Skip to content

Prevent recording race-condition when wifi is enabled#438

Merged
ligenxxxx merged 2 commits intohd-zero:mainfrom
SumolX:dvr_resolution_race_condition
Aug 30, 2024
Merged

Prevent recording race-condition when wifi is enabled#438
ligenxxxx merged 2 commits intohd-zero:mainfrom
SumolX:dvr_resolution_race_condition

Conversation

@SumolX
Copy link
Contributor

@SumolX SumolX commented Aug 27, 2024

Resolves issue #432 where recording is initiated before wifi configuration has completed. This is breakage introduced due to boot up optimization.

@SumolX SumolX marked this pull request as draft August 27, 2024 01:52
@chaotixtech
Copy link

Tested with an eco vtx, 3 flights, all correctly recorded, wifi enabled.

@sanderpuh
Copy link
Contributor

sanderpuh commented Aug 27, 2024

Flashed and tested it, goggles are set to Auto Scan -> Default: Last

When my goggles are booted up using analog, start recording, the problem still persists with the DVR scaling. After going through the menu and back to recording analog, it is properly scaled. So for my scenario it is not yet solved.

For what it's worth, after I switched WiFi to OFF, the issue does no longer show up. Switching it back to ON, and the issue is back.

@SumolX
Copy link
Contributor Author

SumolX commented Aug 27, 2024

Flashed and tested it, goggles are set to Auto Scan -> Default: Last

When my goggles are booted up using analog, start recording, the problem still persists with the DVR scaling. After going through the menu and back to recording analog, it is properly scaled. So for my scenario it is not yet solved.

For what it's worth, after I switched WiFi to OFF, the issue does no longer show up. Switching it back to ON, and the issue is back.

I am still working on it and will supply a proper fix. Root cause has been identified in regards to the race condition.

@SumolX SumolX marked this pull request as ready for review August 27, 2024 23:49
@ligenxxxx ligenxxxx merged commit 9da68d9 into hd-zero:main Aug 30, 2024
@nerdCopter
Copy link
Contributor

fixed AFAICT

@SumolX SumolX deleted the dvr_resolution_race_condition branch April 26, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants