Provide configuration for enabled SSL protocols#530
Merged
romain-grecourt merged 6 commits intomasterfrom Apr 16, 2019
Merged
Conversation
Contributor
Author
|
@barchetta This requires PLS approval work for the netty version update. |
barchetta
approved these changes
Apr 10, 2019
Member
barchetta
left a comment
barchetta
left a comment
There was a problem hiding this comment.
Approved for updating Netty version.
Member
tomas-langer
left a comment
tomas-langer
left a comment
There was a problem hiding this comment.
If we want to have the new properties configurable using Config,
please have a look at SSLContextBuilder.java method public static SSLContext create(Config sslConfig) (I think)
That converts Config to SSL configuration.
romain-grecourt
changed the title
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide configuration for enabled SSL protocols.
Upgrade netty to 4.1.34
Fixes #519