3.x: Fix deadlock health check if invoking the ThreadMXBean fails (#9910)#9911
Merged
barchetta merged 5 commits intohelidon-io:helidon-3.xfrom Mar 28, 2025
Merged
Conversation
tjquinno
requested changes
Mar 17, 2025
Member
tjquinno
left a comment
There was a problem hiding this comment.
Please see the requested change.
health/health-checks/src/main/java/io/helidon/health/checks/DeadlockHealthCheck.java
Show resolved
Hide resolved
tjquinno
requested changes
Mar 17, 2025
health/health/src/main/java/io/helidon/health/HealthSupport.java
Outdated
Show resolved
Hide resolved
tjquinno
approved these changes
Mar 17, 2025
Contributor
Author
|
@tjquinno Can it be merged? Please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9910
The similar logic was done for 4.x. Is it better to be consistent between 3.x and 4.x ?
Unfortunately, we can't return the status
ERROR, because for 3.x exists only statusesUPandDOWN. But we can throwHealthCheckException. I hope, that it's appropriate. ReturnUPwhen app can't getThreadMXBeanis too optimistic.P.S.
DiskSpaceHealthCheckin 3.x does the similar thing: