Fix signature help text cutoff #14969
Open
+20
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ath3
force-pushed
the
sighelp_cutoff
branch
2 times, most recently
from
6951ff2 to
57c5232
Compare
Contributor
|
oooooh I big time like the change of no padding in bordered popups. just to confirm: this is global, for any and all popups? incredible if so! |
Contributor
Author
Yes, everything that is affected by the popup-border configuration setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #13566 introduced issues with signature help resulting in text cutoff, which this PR is intended to fix.
Before:
After:
Update:
I also removed the extra whitespace between borders and text in popups.
Having these margins makes sense with borderless popups, since this space is used to separate the popup text from the background text, but having them in bordered popups makes no sense.
Before:
After:
