Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Fix annotations in svc.yaml#2905

Merged
sameersbn merged 2 commits intohelm:masterfrom
chipironcin:patch-1
Dec 1, 2017
Merged

Fix annotations in svc.yaml#2905
sameersbn merged 2 commits intohelm:masterfrom
chipironcin:patch-1

Conversation

@chipironcin
Copy link
Copy Markdown
Contributor

If .Values.service.annotations is empty (which is the default configuration), the field annotations will be blank, producing a failed deployment.

This patch only adds service annotations if they exist.

If `.Values.service.annotations` is empty (which is the default configuration), the field `annotations` will be blank, producing a failed deployment.

This patch only adds service annotations if they exist.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2017
@sameersbn
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 1, 2017
@sameersbn sameersbn merged commit 91e4fcb into helm:master Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants