chaoskube: add chaoskube helm chart#327
Conversation
|
Hi @linki. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with DetailsIf you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
@k8s-bot ok to test |
viglesiasce
left a comment
viglesiasce
left a comment
There was a problem hiding this comment.
One default change (dryRun->true).
incubator/chaoskube/README.md
Outdated
| | `imageTag` | docker image tag | v0.3.1 | | ||
| | `replicas` | number of replicas to run | 1 | | ||
| | `interval` | interval between pod terminations | 10m | | ||
| | `dryRun` | defines whether pods should actually be terminated | false | |
There was a problem hiding this comment.
Lets make dryRun on by default to protect users from accidentally shooting themselves (and others in the cluster) in the foot. Obviously that is the whole point of installing the chart but better to be safe than sorry.
There was a problem hiding this comment.
I agree and changed it.
|
@viglesiasce I changed the default for dryRun to |
|
Looks good to me @linki! Do you want to move this to stable since it meets all the requirements? |
viglesiasce
added
code reviewed
lgtm
|
@viglesiasce yes, I moved it. Thanks for your review! |
|
wait, I have to update the docs as well... |
|
alright, updated the docs. |
5 participants
this adds a helm chart for chaoskube.
chaoskube is a little tool that periodically kills random pods in your cluster to test how well your applications can deal with failing pods.