[incubator/anchore-engine] Adds incubator chart for Anchore Engine by zhill · Pull Request #3293 · helm/charts

zhill · 2018-01-10T17:28:58Z

Adds Anchore Engine chart to incubator.

To test the service you can hit the API (as described in the NOTES.txt) or use the anchore-cli to query the system. The cli is available here or via pip: pip install anchorecli. The instructions in NOTES indicates how to configure the cli.

k8s-ci-robot · 2018-01-10T17:29:00Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

zhill · 2018-01-10T18:35:11Z

/assign @sameersbn

viglesiasce · 2018-01-10T18:40:25Z

/assign

zhill · 2018-01-10T18:42:29Z

Working on the linter issues in the CircleCI result. Will update with commit to resolve those.

… cli

viglesiasce · 2018-01-11T18:20:36Z

/ok-to-test

viglesiasce · 2018-01-11T18:30:21Z

incubator/anchore-engine/Chart.yaml

+   email: zach@anchore.com
+engine: gotpl
+icon: https://anchore.com/wp-content/uploads/2016/08/anchore.png
+appVersion: 0.1.3


nit, but can you move this to just under the version above.

viglesiasce · 2018-01-11T18:30:44Z

incubator/anchore-engine/README.md

+=========================
+
+This chart deploys the Anchore Engine docker container image analysis system. Anchore Engine
+requires a PostgresSQL database (>=9.6) which may be handled by the chart of supplied externally,


viglesiasce · 2018-01-11T18:35:27Z

incubator/anchore-engine/templates/NOTES.txt

+
+To get the service endpoint:
+
+If using an ingress:


Can you conditionally template this in/out based on whether the ingress is enabled?

viglesiasce · 2018-01-11T18:36:13Z

incubator/anchore-engine/templates/NOTES.txt

+
+or to use the IP instead of service dns name:
+
+    ANCHORE_CLI_URL=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ template "fullname" . }} -o jsonpath="{.spec.clusterIP}")":{{.Values.service.ports.api}}/v1/"


Can you add a "smoke test" here? How do users know that Anchore is installed properly? What can they do with it once its installed? Maybe also point to the user docs.

viglesiasce · 2018-01-11T18:44:03Z

/hold

zhill · 2018-01-12T17:40:16Z

I have addressed the review suggestions and also added a commit to clean up some labelling issues in the deployment definitions to ensure things like 'kubectl get pods -l' filters behave as expected.

zhill · 2018-01-15T22:39:56Z

Moved chart from incubator to stable for PR review per discussion with @viglesiasce

viglesiasce · 2018-01-16T19:18:47Z

Worked a treat! Thanks @zhill!

/lgtm

k8s-ci-robot · 2018-01-16T19:18:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: viglesiasce, zhill

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [viglesiasce]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

viglesiasce · 2018-01-16T19:19:27Z

/hold cancel

zhill · 2018-01-16T20:02:19Z

Thanks @viglesiasce !

Adds incubator chart for Anchore Engine

332b8ff

k8s-ci-robot assigned sameersbn Jan 10, 2018

k8s-ci-robot assigned viglesiasce Jan 10, 2018

viglesiasce unassigned sameersbn Jan 10, 2018

zhill added 4 commits January 10, 2018 11:07

Fixes linter issues on anchore-engine values.yaml

7adbc63

Fixes truth values for values.yaml

d010e9f

Fixes for truthy values in other yaml configs for anchore-engine chart

38be393

Fix ingress spec for anchore-engine chart for easier config with helm…

1879d3e

… cli

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 11, 2018

viglesiasce suggested changes Jan 11, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2018

zhill added 3 commits January 12, 2018 01:44

Addresses typos and some cleanup as requested in PR review

fc9e74c

Adds more startup and config info in NOTES.txt for anchore-engine

0650a43

Cleanup and make labels consistent in anchore-engine deployments

fde13de

Move anchore-engine chart from incubator/ to stable/

82a71ee

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2018

viglesiasce approved these changes Jan 16, 2018

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2018

k8s-ci-robot merged commit c96c95b into helm:master Jan 16, 2018

zhill deleted the anchore_engine branch January 16, 2018 20:02


		or to use the IP instead of service dns name:

		ANCHORE_CLI_URL=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ template "fullname" . }} -o jsonpath="{.spec.clusterIP}")":{{.Values.service.ports.api}}/v1/"

Conversation

zhill commented Jan 10, 2018

Uh oh!

k8s-ci-robot commented Jan 10, 2018

Uh oh!

zhill commented Jan 10, 2018

Uh oh!

viglesiasce commented Jan 10, 2018

Uh oh!

zhill commented Jan 10, 2018

Uh oh!

viglesiasce commented Jan 11, 2018

Uh oh!

viglesiasce Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

viglesiasce Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

viglesiasce Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

viglesiasce Jan 11, 2018

Choose a reason for hiding this comment

Uh oh!

viglesiasce commented Jan 11, 2018

Uh oh!

zhill commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhill commented Jan 15, 2018

Uh oh!

viglesiasce commented Jan 16, 2018

Uh oh!

k8s-ci-robot commented Jan 16, 2018

Uh oh!

viglesiasce commented Jan 16, 2018

Uh oh!

zhill commented Jan 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhill commented Jan 12, 2018 •

edited

Loading