[stable/consul] Pass HttpPort to consul

[jonstacks]

Fixes #1614.

We were not passing the HTTP port through to consul. This fixes it so that consul serves is HTTP interface on the user supplied port.

[lachie83]

/ok-to-test

[lachie83]

/ltgm

[jonstacks]

@lachie83,

From what I can tell, only 2/3 pods in the stateful set were up when the tests ran. I'm wondering if maybe we shouldn't update the helm install command with a --wait flag? Do you think re-running the test might fix it?

Relevant lines from the test:

W0118 23:40:37.065] ++ kubectl get pods --namespace pr-3375-4762 -o 'jsonpath={.items[*].status.containerStatuses[?(@.ready!=true)].name}'
I0118 23:40:37.166] INFO: All pods entered the Running state
I0118 23:40:37.413] INFO: All containers are ready
W0118 23:40:37.513] + UNREADY_CONTAINERS=
W0118 23:40:37.514] + '[' -n '' ']'
W0118 23:40:37.514] + echo 'INFO: All containers are ready'
W0118 23:40:37.514] + exit 0
W0118 23:40:37.514] + kubectl get pods --namespace pr-3375-4762
I0118 23:40:37.722] NAME                   READY     STATUS    RESTARTS   AGE
I0118 23:40:37.723] consul-4762-consul-0   1/1       Running   0          28s
I0118 23:40:37.723] consul-4762-consul-1   0/1       Pending   0          0s
W0118 23:40:37.823] + kubectl get svc --namespace pr-3375-4762
I0118 23:40:38.011] NAME                    CLUSTER-IP     EXTERNAL-IP   PORT(S)                                                                            AGE
I0118 23:40:38.011] consul-4762-consul      None           <none>        8500/TCP,8400/TCP,8301/TCP,8301/UDP,8302/TCP,8302/UDP,8300/TCP,8600/TCP,8600/UDP   29s
I0118 23:40:38.011] consul-4762-consul-ui   10.3.253.253   <nodes>       8500:32432/TCP                                                                     29s
W0118 23:40:38.112] + kubectl get deployments --namespace pr-3375-4762
W0118 23:40:38.304] No resources found.
W0118 23:40:38.307] + kubectl get endpoints --namespace pr-3375-4762
I0118 23:40:38.604] NAME                    ENDPOINTS                                                  AGE
I0118 23:40:38.604] consul-4762-consul      10.0.7.99:8600,10.0.7.99:8400,10.0.7.99:8302 + 6 more...   29s
I0118 23:40:38.604] consul-4762-consul-ui   10.0.7.99:8500                                             29s
W0118 23:40:38.705] + helm test consul-4762

[jonstacks]

/retest

[jonstacks]

Had to update part of the tests to get this to pass. Not sure if this is the best place to do it or if we should make modifications to the /test/verify-release.sh which checks for all pods being available.

[lachie83]

@jonstacks --wait has had issue between releases in the past. How about we make the helm test script handle the cluster coming up for some predetermined time -- https://github.com/kubernetes/charts/blob/master/stable/consul/templates/test-config.yaml

[jonstacks]

@lachie83, Sounds good. I'll Remove the wait and update the consul test.

[jonstacks]

@lachie83,

I think this should be good to go now.

[lachie83]

/approve

[lachie83]

Thanks!

[jonstacks]

@lachie83, I'm thinking your /lgtm from earlier didn't register.

[lachie83]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonstacks, lachie83

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [lachie83]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment