Skip to content

style: no-multi-assign#3744

Merged
curbengh merged 2 commits into
hexojs:masterfrom
curbengh:no-multi-assign
Oct 17, 2019
Merged

style: no-multi-assign#3744
curbengh merged 2 commits into
hexojs:masterfrom
curbengh:no-multi-assign

Conversation

@curbengh

@curbengh curbengh commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

What does it do?

hexojs/eslint-config-hexo#22

ref: https://eslint.org/docs/rules/no-multi-assign

How to test

git clone -b no-multi-assign https://github.com/USER/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Passed the CI test.

@coveralls

coveralls commented Oct 2, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.02%) to 97.293% when pulling 2ed258e on curbengh:no-multi-assign into a8bb7b8 on hexojs:master.

@curbengh

curbengh commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

warehouse also have plenty of multi-assign, so it depends whether we shall proceed all the way.

@tomap

tomap commented Oct 2, 2019

Copy link
Copy Markdown
Contributor

warehouse also have plenty of multi-assign, so it depends whether we shall proceed all the way.

not sure what you mean by that. But the code already looks good.
Maybe trying to play nice with code climate could be cool

@curbengh

curbengh commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

I mean this eslint rule involves the very core of hexo, so we need to thread carefully.

@curbengh curbengh merged commit 78b5d8b into hexojs:master Oct 17, 2019
@curbengh curbengh deleted the no-multi-assign branch October 17, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants