Skip to content

style: chained assignment#3986

Merged
SukkaW merged 2 commits into
hexojs:masterfrom
curbengh:chain-assignment
Dec 18, 2019
Merged

style: chained assignment#3986
SukkaW merged 2 commits into
hexojs:masterfrom
curbengh:chain-assignment

Conversation

@curbengh

@curbengh curbengh commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

What does it do?

Avoid issue #3985, to avoid calling a function twice (e.g. dirname()). The returned result of a function is referred instead.

How to test

git clone -b chain-assignment https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls

coveralls commented Dec 18, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 97.117% when pulling 3808441 on curbengh:chain-assignment into 5179a6a on hexojs:master.

@curbengh curbengh requested a review from SukkaW December 18, 2019 09:01
SukkaW
SukkaW previously approved these changes Dec 18, 2019
Comment thread lib/extend/console.js Outdated
Comment thread lib/extend/filter.js Outdated
@SukkaW SukkaW merged commit 5a503ff into hexojs:master Dec 18, 2019
@curbengh curbengh deleted the chain-assignment branch December 18, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants