fix(engine): hold last frame for non-looping videos past source end#1044
Closed
miguel-heygen wants to merge 3 commits into
Closed
fix(engine): hold last frame for non-looping videos past source end#1044miguel-heygen wants to merge 3 commits into
miguel-heygen wants to merge 3 commits into
Conversation
When a <video> source is shorter than data-duration without loop, getFrameAtTime() and getActiveFramePayloads() returned null for frames past the source end — the frame injector skipped the element and headless Chrome rendered black. Browser preview holds the last frame natively (per HTML spec), creating a preview/render divergence. Remove the loop guard so both looping and non-looping videos return the last extracted frame when seeking past the source duration. Closes #1043
Add getFrameAtTime regression test covering source shorter than data-duration: verifies last frame is returned (not null) when seeking past source end for non-looping videos. Strengthens the FrameLookupTable test to check at both 1.5s and 4.9s (near timeline end) to guard against future regressions.
Adds a producer regression test with a 2s source video and 4s data-duration (no loop). Validates that the rendered output holds the last frame instead of going black after the source ends. Baseline generated inside Docker (Dockerfile.test) — 100 visual checkpoints and audio comparison all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #1043