Fix process crash on network error during RTM reconnect#121
Merged
Conversation
…nect uncaughtException ハンドラが RTMClient.js 由来のエラーしか握りつぶしておらず、 WebClient.js から来る ENOTFOUND などのネットワークエラーが throw されてプロセスが クラッシュしていた問題を修正。isNetworkError() で判定してリトライ処理に繋げる。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uncaughtExceptionハンドラがRTMClient.js由来のエラーしか握りつぶしておらず、WebClient.jsから来るENOTFOUNDなどの DNS/ネットワークエラーがthrowされてプロセスがクラッシュしていた問題を修正isNetworkError()で判定し、ネットワークエラーの場合はscheduleRtmRestart()を呼んで既存の exponential backoff リトライ処理に繋げるよう変更再現ケース
PC スリープ復帰直後、RTM 再接続リトライを2〜3回繰り返した後に以下のエラーでプロセスが終了していた：
Test plan
🤖 Generated with Claude Code