Add frozen string literal + small update #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `spec` from files (spec are included when gem installed) Remove `test_files` (not required anymore)
Fix frozen_string_literal
highb
approved these changes
Apr 10, 2024
Owner
highb
left a comment
highb
left a comment
There was a problem hiding this comment.
I've reviewed the changes and run the checks. It looks like everything works, so this LGTM. Thanks for the contributions! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While enabling
frozen_string_literalthrough the RUBYOPT, I've stumble your gem that doesn't comply with that feature. I took the opportunity to enable it through this PR. I've also regenerated Rubocop's todo and it's TargetRubyVersion. Finally, I found thatspecfiles are present when installing the gem. I don't know if you want to keep them but it's adding a little weight on the file size.Thanks