Set scheduler_specific_kwargs to get_scheduler#4006
Merged
hiyouga merged 1 commit intohiyouga:mainfrom Jun 3, 2024
Merged
Conversation
Contributor
Author
|
A |
yoonseok312
pushed a commit
to pensieve-ai/LLaMA-Factory-vlm
that referenced
this pull request
Apr 29, 2025
Set scheduler_specific_kwargs to get_scheduler Former-commit-id: 0f01500
liu-qingyuan
pushed a commit
to liu-qingyuan/LLaMA-Factory-Megafake
that referenced
this pull request
Jun 6, 2025
Set scheduler_specific_kwargs to get_scheduler Former-commit-id: 0f01500
zhongwei1968
pushed a commit
to zhongwei1968/LLaMA-Factory
that referenced
this pull request
Aug 1, 2025
Set scheduler_specific_kwargs to get_scheduler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When setting the argument
--lr_scheduler_type cosine_with_min_lrforpython src/train.py, the following error occurs:In response, I provided the argument
--lr_scheduler_kwargs '{"min_lr": 1e-7}', but an error still occurs because thescheduler_specific_kwargsargument is not properly passed to theget_schedulerfunction within thecreate_custom_schedulerfunction insrc/llamafactory/train/utils.py.To resolve this error, I have modified the code to set the
scheduler_specific_kwargsargument totraining_args.lr_scheduler_kwargswithin thecreate_custom_schedulerfunction.Before submitting