Enforce strict type safety: ban 'any' and restrict 'as' - #120
Conversation
…'as' - Update `biome.json` to enable `lint/suspicious/noExplicitAny` as an error. - Remove invalid `ultracite` extension from `biome.json`. - Update `AGENTS.md` coding conventions: - Explicitly forbid `any`. - Restrict `as` type assertions (except `as const`). - Advise against using deprecated APIs. Co-authored-by: hmjn023 <76728956+hmjn023@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @hmjn023, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the codebase's type safety by implementing stricter TypeScript rules. It introduces a ban on explicit Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
このプルリクエストは、any 型を禁止し as 型アサーションを制限することで、コードベース全体の型安全性を強化するものです。biome.json に noExplicitAny ルールを追加し、AGENTS.md のコーディング規約を更新する変更は、この目的に沿った素晴らしい改善です。
一点だけ、biome.json から "extends": ["ultracite"] が削除されている点について懸念があります。これにより他の重要なルールが無効化される可能性がないか、ご確認をお願いします。詳細はファイルへのコメントをご参照ください。
- Create `tools/deprecation-checker` with isolated ESLint configuration. - Implement `Detect Deprecated Code` GitHub Actions workflow. - Detect `@deprecated` usage in `apps/` and `packages/` via `eslint-plugin-deprecation`. - Auto-report findings as PR comments or GitHub Issues. Co-authored-by: hmjn023 <76728956+hmjn023@users.noreply.github.com>
This change enforces stricter type safety rules across the codebase.
It modifies the Biome configuration to treat explicit
anyusage as an error.It also updates the
AGENTS.mddocumentation to formally banastype assertions (with the exception ofas const) and provides guidelines on avoiding deprecated APIs.Existing
anyusages remain in the codebase and will be reported as errors until fixed, as per the migration strategy.PR created automatically by Jules for task 4576493856382647777 started by @hmjn023