fix(ui): App ShellとRouter境界を安定化する (#577) - #590
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughServer/TauriのRouterにpending/error/not-foundの既定表示を追加し、共通の状態UIを新設しました。AppShellはstatusIndicatorを受け取るようになり、Tauriは初期化完了までBootstrap画面を表示します。NotFoundScreenも更新されました。 ChangesRouter Pending/Error基盤とApp Shell統合
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/router-status.tsx`:
- Around line 129-174: BootstrapStatusScreen has conflicting live-region
behavior because the section always sets aria-live to polite even when it
switches to role="alert" in the error state. Update BootstrapStatusScreen so the
live region matches the state: keep the non-error status announcement polite,
but make the error path assertive by adjusting the aria-live value conditionally
alongside the role prop. Use BootstrapStatusScreen, the props.error check, and
the section element as the main points to locate and fix this.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3e88054b-5230-4927-8e4e-d8d80b4d9875
📒 Files selected for processing (8)
apps/server/src/router.tsxapps/server/src/routes/__root.tsxapps/tauri/src/main.tsxapps/tauri/src/router.tsxapps/tauri/src/routes/__root.tsxpackages/ui/src/layouts/app-shell.tsxpackages/ui/src/router-status.tsxpackages/ui/src/screens/not-found-screen.tsx
概要
Server/Tauriで起動・loader待機・route失敗時にもApp Shellを維持し、白画面にならない共通基盤を追加します。
変更内容
検証
fixes #577
Summary by CodeRabbit