feat(db): add migration-backed job and source state - #665
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
82e0016 to
ba5394d
Compare
| attemptCount: requireNumber(raw.attemptCount, "attemptCount"), | ||
| startedAt: nullableDate(raw.startedAt, "startedAt"), | ||
| finishedAt: nullableDate(raw.finishedAt, "finishedAt"), | ||
| artifactPath: nullableString(raw.artifactPath, "artifactPath"), |
There was a problem hiding this comment.
[P1] 新しいclaim rowフィールドに合わせてrepositoryテストのfixtureを更新してください
このmapperは今回追加された artifactPath などを必須のnullableフィールドとして読み取りますが、packages/db/src/repositories/job-repository.test.ts の execute fixtureにはこれらの列がありません。現状、focusedなrepository testは Invalid claimed job row: artifactPath で失敗し、fixtureを補っても stale recovery の2段階updateに対する期待値も古いままです。実装と同じPRでテストfixture・requeue期待値も更新してください。
Stack created with GitHub Stacks CLI • Give Feedback 💬