Skip to content

feat(db): add migration-backed job and source state - #665

Open
hmjn023 wants to merge 1 commit into
feat/v2-no-migration-featuresfrom
feat/v2-migration-foundation
Open

feat(db): add migration-backed job and source state#665
hmjn023 wants to merge 1 commit into
feat/v2-no-migration-featuresfrom
feat/v2-migration-foundation

Conversation

@hmjn023

@hmjn023 hmjn023 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Stack created with GitHub Stacks CLIGive Feedback 💬

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 85bf98e8-2f47-436e-9275-f74e375e02ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hmjn023
hmjn023 force-pushed the feat/v2-migration-foundation branch from 82e0016 to ba5394d Compare August 10, 2026 15:22

@hmjn023 hmjn023 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加レビューです。#663 に既にある指摘とは別に、関連テストの回帰を確認しました。merge前に修正をお願いします。

attemptCount: requireNumber(raw.attemptCount, "attemptCount"),
startedAt: nullableDate(raw.startedAt, "startedAt"),
finishedAt: nullableDate(raw.finishedAt, "finishedAt"),
artifactPath: nullableString(raw.artifactPath, "artifactPath"),

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] 新しいclaim rowフィールドに合わせてrepositoryテストのfixtureを更新してください

このmapperは今回追加された artifactPath などを必須のnullableフィールドとして読み取りますが、packages/db/src/repositories/job-repository.test.tsexecute fixtureにはこれらの列がありません。現状、focusedなrepository testは Invalid claimed job row: artifactPath で失敗し、fixtureを補っても stale recovery の2段階updateに対する期待値も古いままです。実装と同じPRでテストfixture・requeue期待値も更新してください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant