This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Making the PrivateBin container image more robust#11
Merged
Conversation
…the web root, making image support read-only operation, consistent white spaces in nginx config
Author
|
FYI: I have merged your latest changes and updated the PR for the new release 1.2.1. |
Owner
|
Thank your very much @elrido for your effort! |
Owner
|
After some testing I merged it into master. Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear @hoellen,
Please find attached some changes to the PrivateBin docker image, the main goal being to implement the projects recommendations for installation of the software. The key changes and reasoning for them:
Thank you for maintaining these @Wonderfall containers and especially the PrivateBin one. I hope you find these changes useful. Let me know if you would like me to adjust any of these points.
Best regards,
El RIDO