Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Making the PrivateBin container image more robust#11

Merged
hoellen merged 4 commits into
hoellen:privatebin-devfrom
elrido:master
Aug 12, 2018
Merged

Making the PrivateBin container image more robust#11
hoellen merged 4 commits into
hoellen:privatebin-devfrom
elrido:master

Conversation

@elrido
Copy link
Copy Markdown

@elrido elrido commented Aug 1, 2018

Dear @hoellen,

Please find attached some changes to the PrivateBin docker image, the main goal being to implement the projects recommendations for installation of the software. The key changes and reasoning for them:

  • adding a gpg signature check for the PrivateBin archive - while it is downloaded over HTTPS, this guarantees the archive hasn't been tampered with after we signed the release archive.
  • splitting the installation between web root and libraries / data - further reduces any risk of exposing unparsed PHP files or even data (I kept the current /privatebin folder for the data, the web root now is in /srv).
  • made the image support read-only operation - this is optional, but prevents any exploits to change the scripts or binaries in the container.
  • removed ca-certificates & libressl packages from BUILD_DEPS, since they are already installed in the hoellen/nginx-php container as a curl dependency and therefore fail to be removed in this layer.

Thank you for maintaining these @Wonderfall containers and especially the PrivateBin one. I hope you find these changes useful. Let me know if you would like me to adjust any of these points.

Best regards,
El RIDO

@elrido
Copy link
Copy Markdown
Author

elrido commented Aug 11, 2018

FYI: I have merged your latest changes and updated the PR for the new release 1.2.1.

@hoellen hoellen changed the base branch from master to privatebin-dev August 12, 2018 07:38
@hoellen
Copy link
Copy Markdown
Owner

hoellen commented Aug 12, 2018

Thank your very much @elrido for your effort!
It looks really good and I merging this in a new branch for now.

@hoellen hoellen merged commit a785f9c into hoellen:privatebin-dev Aug 12, 2018
@hoellen
Copy link
Copy Markdown
Owner

hoellen commented Aug 12, 2018

After some testing I merged it into master. Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants