Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ESPHome tests
  • Loading branch information
synesthesiam committed Nov 6, 2023
commit cc16d475b4680aee3f4df1cd1f95e84a6d496d71
4 changes: 3 additions & 1 deletion homeassistant/components/esphome/voice_assistant.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def __init__(
self.handle_event = handle_event
self.handle_finished = handle_finished
self._tts_done = asyncio.Event()
self._tts_task: asyncio.Task | None = None

async def start_server(self) -> int:
"""Start accepting connections."""
Expand Down Expand Up @@ -191,7 +192,7 @@ def _event_callback(self, event: PipelineEvent) -> None:

if self.device_info.voice_assistant_version >= 2:
media_id = event.data["tts_output"]["media_id"]
self.hass.async_create_background_task(
self._tts_task = self.hass.async_create_background_task(
self._send_tts(media_id), "esphome_voice_assistant_tts"
)
else:
Expand Down Expand Up @@ -353,4 +354,5 @@ async def _send_tts(self, media_id: str) -> None:
self.handle_event(
VoiceAssistantEventType.VOICE_ASSISTANT_TTS_STREAM_END, {}
)
self._tts_task = None
self._tts_done.set()
37 changes: 36 additions & 1 deletion tests/components/esphome/test_voice_assistant.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
"""Test ESPHome voice assistant server."""

import asyncio
import io
import socket
from unittest.mock import Mock, patch
import wave

from aioesphomeapi import VoiceAssistantEventType
import pytest
Expand Down Expand Up @@ -340,9 +342,18 @@ async def test_send_tts(
voice_assistant_udp_server_v2: VoiceAssistantUDPServer,
) -> None:
"""Test the UDP server calls sendto to transmit audio data to device."""
with io.BytesIO() as wav_io:
with wave.open(wav_io, "wb") as wav_file:
wav_file.setframerate(16000)
wav_file.setsampwidth(2)
wav_file.setnchannels(1)
wav_file.writeframes(bytes(_ONE_SECOND))

wav_bytes = wav_io.getvalue()

with patch(
"homeassistant.components.esphome.voice_assistant.tts.async_get_media_source_audio",
return_value=("raw", bytes(1024)),
return_value=("wav", wav_bytes),
):
voice_assistant_udp_server_v2.transport = Mock(spec=asyncio.DatagramTransport)

Expand All @@ -360,6 +371,30 @@ async def test_send_tts(
voice_assistant_udp_server_v2.transport.sendto.assert_called()


async def test_send_tts_wrong_format(
hass: HomeAssistant,
voice_assistant_udp_server_v2: VoiceAssistantUDPServer,
) -> None:
"""Test that only WAV audio will be streamed."""
with patch(
"homeassistant.components.esphome.voice_assistant.tts.async_get_media_source_audio",
return_value=("raw", bytes(1024)),
), pytest.raises(ValueError):
voice_assistant_udp_server_v2.transport = Mock(spec=asyncio.DatagramTransport)

voice_assistant_udp_server_v2._event_callback(
PipelineEvent(
type=PipelineEventType.TTS_END,
data={
"tts_output": {"media_id": _TEST_MEDIA_ID, "url": _TEST_OUTPUT_URL}
},
)
)

assert voice_assistant_udp_server_v2._tts_task is not None
await voice_assistant_udp_server_v2._tts_task # raises ValueError


async def test_wake_word(
hass: HomeAssistant,
voice_assistant_udp_server_v2: VoiceAssistantUDPServer,
Expand Down