Fixed Kodi Media Browsing by albaintor · Pull Request #165819 · home-assistant/core

albaintor · 2026-03-17T17:00:06Z

Proposed change

This is a fix for Kodi media browsing : the can_play flag was evaluated as a string with the previous expression instead of a boolean.
Maybe other components with browsing support have copied/paste this bug : I have found another one -> Roku

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-03-17T17:00:15Z

Hey there @OnFreund, mind taking a look at this pull request as it has been labeled with an integration (kodi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of kodi can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign kodi Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

This PR fixes media browsing behavior in the Kodi integration by ensuring the BrowseMedia.can_play field is evaluated as a proper boolean instead of sometimes becoming a string.

Changes:

Adjust can_play calculation in Kodi media browsing to always produce a boolean value.

        media_content_type=search_type,
        title=title,
-        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id,
+        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id is not None and search_id != "",


        media_content_type=search_type,
        title=title,
-        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id,
+        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id is not None and search_id != "",


edenhaus

Please fix the CI and make sure it's passing

home-assistant · 2026-04-09T17:29:49Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot

Pull request overview

Fixes Kodi media browsing by ensuring the BrowseMedia.can_play field is evaluated as a proper boolean (instead of potentially becoming a non-bool truthy value).

Changes:

Update Kodi browse-media response building to compute can_play as a boolean expression.

Copilot · 2026-04-20T08:18:10Z

        media_content_type=search_type,
        title=title,
-        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id,
+        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id is not None and search_id != "",


Align the PR description/checklist with the actual diff (either include the mentioned Roku fix/tests, or update the description to only reference the Kodi change).

joostlek

The CI is still failing, can you take a look?

joostlek · 2026-04-20T09:08:45Z

Euh the CI wasn't complaining about bool, it was complaining about the line wrapping

albaintor · 2026-04-20T09:10:26Z

Euh the CI wasn't complaining about bool, it was complaining about the line wrapping

Yes I know that but I prefered to reproduce the same code as other integrations (jelly for example)

albaintor · 2026-04-20T09:11:09Z

The CI is still failing, can you take a look?

Finally I changed the code to stick to other media browsing implementations such as jellyfin

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot · 2026-04-20T09:13:17Z

        title=title,
-        can_play=search_type in PLAYABLE_MEDIA_TYPES and search_id,
+        can_play=bool(search_type in PLAYABLE_MEDIA_TYPES and search_id),


Clarify whether this PR is intentionally Kodi-only, since the same can_play=... and search_id pattern (returning a str) still exists in homeassistant/components/roku/browse_media.py and may need a separate fix/PR.

The origin of this PR : in some situations, can_play evaluates to a string instead of a boolean. This PR prevents this by forcing the type to boolean

CI passes

Fix can_play condition to check for None and empty string

dc8edbe

Copilot AI review requested due to automatic review settings March 17, 2026 17:00

home-assistant Bot added bugfix cla-signed integration: kodi small-pr PRs with less than 30 lines. labels Mar 17, 2026

home-assistant Bot added the Quality Scale: No score label Mar 17, 2026

Copilot started reviewing on behalf of albaintor March 17, 2026 17:01 View session

Copilot AI reviewed Mar 17, 2026

View reviewed changes

edenhaus previously requested changes Apr 9, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft April 9, 2026 17:29

Merge branch 'dev' into fixed_media_browsing

a8f8e90

albaintor marked this pull request as ready for review April 20, 2026 08:15

Copilot AI review requested due to automatic review settings April 20, 2026 08:15

home-assistant Bot requested a review from edenhaus April 20, 2026 08:15

Copilot started reviewing on behalf of albaintor April 20, 2026 08:15 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

joostlek requested changes Apr 20, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft April 20, 2026 08:38

Fixed : changing condition to respect target format

54899d2

Merge branch 'dev' into fixed_media_browsing

4fdb02e

Copilot AI review requested due to automatic review settings April 20, 2026 09:10

albaintor marked this pull request as ready for review April 20, 2026 09:10

home-assistant Bot requested a review from joostlek April 20, 2026 09:10

Copilot started reviewing on behalf of albaintor April 20, 2026 09:11 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

joostlek approved these changes Apr 20, 2026

View reviewed changes

joostlek merged commit 0ebf4d8 into home-assistant:dev Apr 20, 2026
36 of 37 checks passed

joostlek added this to the 2026.4.4 milestone Apr 20, 2026

github-actions Bot locked and limited conversation to collaborators Apr 21, 2026

frenck added the cherry-picked label Apr 24, 2026

Uh oh!

Conversation

albaintor commented Mar 17, 2026

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Mar 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

edenhaus left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

joostlek commented Apr 20, 2026

Uh oh!

albaintor commented Apr 20, 2026

Uh oh!

albaintor commented Apr 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

albaintor Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants