Fix Proxmox VE storage usage percentage crash on missing used_fraction#167136
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @irishpadres,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
e26691fed57e61008a2120390fae0c4fc63690ca- This commit has something that looks like an email address (root@tahoe.kobrien.net). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
home-assistant
Bot
added
bugfix
cla-error
has-tests
integration: proxmoxve
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @Corbeno, @erwindouna, @CoMPaTech, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Some Proxmox storage types do not return a `used_fraction` field in the API response, causing a KeyError when the storage usage percentage sensor tries to access it. Use `dict.get()` to gracefully handle the missing key and report the sensor as unknown instead of crashing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
irishpadres
force-pushed
the
fix-proxmoxve-storage-used-fraction
branch
from
e26691f to
ac1eeb4
Compare
There was a problem hiding this comment.
Pull request overview
This pull request fixes a KeyError crash in the Proxmox VE integration's storage usage percentage sensor. Certain storage types (like PBS datastores and pass-through mounts) don't include the used_fraction field in the Proxmox API response, causing the sensor to fail. The fix changes from direct dictionary access to using .get() with proper None handling, allowing the sensor to gracefully show "Unknown" in the UI when the field is absent.
Changes:
- Updated storage usage percentage sensor to use safe dictionary access for the
used_fractionfield - Added test coverage for the case where
used_fractionis missing from storage data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| homeassistant/components/proxmoxve/sensor.py | Fixed KeyError crash by using data.get("used_fraction") instead of data["used_fraction"] with proper None handling |
| tests/components/proxmoxve/test_sensor.py | Added test case validating graceful handling when used_fraction is missing from storage data |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erwindouna
left a comment
erwindouna
left a comment
There was a problem hiding this comment.
Thanks @irishpadres! A few points to look into. :)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| ): | ||
| await setup_integration(hass, mock_config_entry) | ||
|
|
||
| state = hass.states.get("sensor.storage_local_storage_usage_percentage") |
There was a problem hiding this comment.
The test could be more defensive by explicitly checking that the state entity exists before accessing its state attribute. Without this check, a missing entity would raise an AttributeError instead of providing a clear assertion failure message.
| state = hass.states.get("sensor.storage_local_storage_usage_percentage") | |
| state = hass.states.get("sensor.storage_local_storage_usage_percentage") | |
| assert state is not None |
erwindouna
left a comment
erwindouna
left a comment
There was a problem hiding this comment.
Looks good, thanks! Might ti check in the CLA error,before we can continue.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
cla error should be resolved now. |
Proposed change
Fix
KeyError: 'used_fraction'crash in the Proxmox VE integration's storage usage percentage sensor. Certain storage types (e.g., PBS datastores, pass-through mounts) do not include theused_fractionfield in the Proxmox API response, causing the sensor to crash.The fix changes
data["used_fraction"]todata.get("used_fraction")so the sensor gracefully returnsNone(showing "Unknown" in the UI) when the key is absent instead of raising aKeyError.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: