Refactor indevolt integration to remove magic number constants#169337
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Indevolt integration to replace hard-coded numeric read/write keys with constants provided by the updated indevolt-api library.
Changes:
- Bump
indevolt-apidependency to1.6.3and update integration imports accordingly. - Replace magic key strings across platforms (sensor/select/number/switch/coordinator/diagnostics) with
indevolt_apiconstants. - Update Indevolt tests to use the same upstream constants and enums.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/components/indevolt/test_switch.py | Switch tests updated to use IndevoltConfig constants for read/write keys. |
| tests/components/indevolt/test_services.py | Service tests updated to use IndevoltConfig + IndevoltEnergyMode instead of integration constants. |
| tests/components/indevolt/test_select.py | Select tests updated to use upstream energy mode enum/constants. |
| tests/components/indevolt/test_number.py | Number tests updated to use IndevoltConfig constants for read/write keys. |
| tests/components/indevolt/test_button.py | Button tests updated to use upstream constants/enums for energy-mode interactions. |
| requirements_test_all.txt | Pin indevolt-api==1.6.3 for test environment. |
| requirements_all.txt | Pin indevolt-api==1.6.3 for runtime environment. |
| homeassistant/components/indevolt/switch.py | Switch entity descriptions refactored to use upstream read/write key constants. |
| homeassistant/components/indevolt/sensor.py | Sensor keys and battery-pack key groupings refactored to upstream constants. |
| homeassistant/components/indevolt/select.py | Select mapping refactored to use IndevoltEnergyMode + upstream config keys. |
| homeassistant/components/indevolt/number.py | Number entity descriptions refactored to use upstream read/write key constants. |
| homeassistant/components/indevolt/manifest.json | Integration requirement bumped to indevolt-api==1.6.3. |
| homeassistant/components/indevolt/diagnostics.py | Diagnostics redaction keys refactored to upstream constants. |
| homeassistant/components/indevolt/coordinator.py | Energy-mode switching refactored to use upstream keys/enums; discharge-limit access updated. |
| homeassistant/components/indevolt/const.py | Polling key lists refactored to upstream constants. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Refactored code base to remove magic number constants from the core integration: they will now come from the updated external library.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: