Skip to content

Bump python-duco-client to 0.4.1#169991

Merged
zweckj merged 1 commit into
home-assistant:devfrom
ronaldvdmeer:fix/duco-network-type-wi-169985
May 7, 2026
Merged

Bump python-duco-client to 0.4.1#169991
zweckj merged 1 commit into
home-assistant:devfrom
ronaldvdmeer:fix/duco-network-type-wi-169985

Conversation

@ronaldvdmeer
Copy link
Copy Markdown
Contributor

@ronaldvdmeer ronaldvdmeer commented May 7, 2026

Proposed change

Bump python-duco-client from 0.4.0 to 0.4.1.

The new release adds WI (Wi-Fi) to the NetworkType enum and falls back to NetworkType.UNKNOWN for any future unrecognised network type values. Without this fix, Duco installations with Wi-Fi-connected room nodes crash on every coordinator update with ValueError: 'WI' is not a valid NetworkType, making the entire integration unavailable.

Changelog: https://github.com/ronaldvdmeer/python-duco-client/releases/tag/v0.4.1
Diff: ronaldvdmeer/python-duco-client@v0.4.0...v0.4.1

Note

This PR fixes a crash affecting existing users. Please assign it to the first upcoming bugfix milestone.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

Copilot AI review requested due to automatic review settings May 7, 2026 09:30
@home-assistant home-assistant Bot added cla-signed dependency Pull requests marked as a dependency upgrade integration: duco small-pr PRs with less than 30 lines. by-code-owner Quality Scale: platinum labels May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the Duco integration’s python-duco-client dependency to 0.4.1 to prevent crashes when devices report the WI network type and to handle future unknown network types safely.

Changes:

  • Update homeassistant.components.duco to require python-duco-client==0.4.1.
  • Regenerate/update derived requirement pin files to reflect the new version.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
homeassistant/components/duco/manifest.json Bumps the integration requirement to python-duco-client==0.4.1.
requirements_all.txt Updates the global pinned dependency list to python-duco-client==0.4.1.
requirements_test_all.txt Updates the test pinned dependency list to python-duco-client==0.4.1.

Comment thread homeassistant/components/duco/manifest.json
@epenet epenet changed the title Bump python-duco-client to 0.4.1 (fix WI NetworkType) Bump python-duco-client to 0.4.1 May 7, 2026
@epenet epenet added this to the 2026.5.1 milestone May 7, 2026
Copy link
Copy Markdown
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the future please include the tag diff also in the PR description, thanks!

@zweckj zweckj merged commit ff69557 into home-assistant:dev May 7, 2026
51 of 52 checks passed
@ronaldvdmeer
Copy link
Copy Markdown
Contributor Author

for the future please include the tag diff also in the PR description, thanks!

Thanks for the merge. I did include a diff in the PR description, though perhaps a different diff was expected?

@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Duco integration shows initialization issue with WiFi connected communication board (v1)

5 participants