Skip to content

Remove 'tariff' edition from options-flow#85703

Merged
jbouwh merged 4 commits intohome-assistant:devfrom
azogue:chore/fix-pvpc-options
Jan 13, 2023
Merged

Remove 'tariff' edition from options-flow#85703
jbouwh merged 4 commits intohome-assistant:devfrom
azogue:chore/fix-pvpc-options

Conversation

@azogue
Copy link
Copy Markdown
Member

@azogue azogue commented Jan 11, 2023

Proposed change

TL;DR

The entry.data[ATTR_TARIFF] is what makes the entry.unique_id, so it's an incoherence to be able to change it in the Options flow.

Long version
There are only 2 tariffs, and it's a geographical option, so normally the user has only 1 entry, and does not play with that,

BUT, in this borderline-scenario:

  • setup of 1st entry with tariff-1
  • go to options and change to tariff-2 (it's unique ID doesn't change, and it's equal to tariff-1)
  • setup a 2nd entry with tariff-1 ==> 🧨 Invalid, as already configured
  • setup a 2nd entry with tariff-2 --> OK, setting unique_id=tariff-2, but the sensor it's the same as the 1st entry, and needs to go to options to swap tariff 💩🤪

So the best action to prevent that is to remove that option 🔥

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

The `entry.data["tariff"]` is what makes the `entry.unique_id`,
so it's an incoherence to be able to change it in the Options flow
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouwh jbouwh merged commit d748894 into home-assistant:dev Jan 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants