Merged
Conversation
Contributor
Author
|
@horahoradev |
Owner
|
There wouldn't be any proxy for yarn, no. It does build fine on the CI tests. |
Owner
|
I don't see any issues with this... but I'll merge it tomorrow morning; apologies for the delay. Thank you for your contribution! |
horahoradev
approved these changes
Jun 19, 2022
|
|
||
| RUN yarn install | ||
|
|
||
| RUN cd /webapp && \ |
Owner
There was a problem hiding this comment.
so this way we won't have to reinstall deps when we change the src (lol). much better
| **/.git | ||
| **/.gitignore | ||
| **/.vscode | ||
| **/Dockerfile* |
Owner
There was a problem hiding this comment.
oh, interesting, I hadn't heard of a dockerignore file
Owner
|
merged, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.dockerignoreto webapp so it wouldn't dump the local build artifacts andnode_modulesfolder into the image