Skip to content

refactor: webapp ci#47

Merged
horahoradev merged 3 commits intohorahoradev:devfrom
GabenGar:webapp-dockerfile
Jun 19, 2022
Merged

refactor: webapp ci#47
horahoradev merged 3 commits intohorahoradev:devfrom
GabenGar:webapp-dockerfile

Conversation

@GabenGar
Copy link
Contributor

@GabenGar GabenGar commented Jun 18, 2022

  • added .dockerignore to webapp so it wouldn't dump the local build artifacts and node_modules folder into the image
  • changed dockerfile so it would actually install with yarn and the package cache wouldn't bust on every source code change

@GabenGar
Copy link
Contributor Author

@horahoradev
For some reason yarn couldn't fetch the packages when ran from the docker stack. Installs fine from the local setup though.
Does horahora use some kind of proxy and can you check if the webapp image builds for you?

@horahoradev
Copy link
Owner

There wouldn't be any proxy for yarn, no. It does build fine on the CI tests.

@horahoradev
Copy link
Owner

I don't see any issues with this... but I'll merge it tomorrow morning; apologies for the delay. Thank you for your contribution!

@GabenGar GabenGar marked this pull request as ready for review June 19, 2022 07:21
Copy link
Owner

@horahoradev horahoradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW!


RUN yarn install

RUN cd /webapp && \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this way we won't have to reinstall deps when we change the src (lol). much better

**/.git
**/.gitignore
**/.vscode
**/Dockerfile*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, interesting, I hadn't heard of a dockerignore file

@horahoradev horahoradev merged commit ab61ba0 into horahoradev:dev Jun 19, 2022
@horahoradev
Copy link
Owner

merged, thank you!

@GabenGar GabenGar deleted the webapp-dockerfile branch June 20, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants