Skip to content

feat: Mock Client tracks request objects received in the sendRequest method#8

Merged
ralflang merged 1 commit into
FRAMEWORK_6_0from
feat/mock-request-recording
Jul 11, 2026
Merged

feat: Mock Client tracks request objects received in the sendRequest method#8
ralflang merged 1 commit into
FRAMEWORK_6_0from
feat/mock-request-recording

Conversation

@ralflang

@ralflang ralflang commented Jul 11, 2026

Copy link
Copy Markdown
Member

Make the Horde\Http\ mock client (PSR-18) record which requests were supposed to be sent. This makes it more attractive for API Client tests (such as horde/service_twitter, horde/service_weather, horde/service_facebook, horde/githubapiclient) and be less reliant on cumbersome-to-maintain PHPUnit mocks.

@github-actions

Copy link
Copy Markdown

🔍 CI Results

Overall: ❌ 10/10 lanes failed

TL;DR: ❌ Quality issues: PHPUnit: 2 tests failed; PHPStan: 142 unique errors in 8 lanes.

Summary by PHP Version

PHP dev stable
8.1
8.2
8.3
8.4
8.5

Quality Metrics

  • PHPUnit: 0 failures, 2 errors out of 229 tests in 8 lanes ❌
    Per-test detail in the table below. Raw JUnit XML and JSON are uploaded as workflow artifacts.

    Which tests failed
    Type Test Lanes Message
    ⚠️ error Horde\Http\Test\Unit\CookieParserTest::parseIgnoresMalformedExpires php8.3-dev, php8.3-stable [Error] Cannot create dynamic property DateMalformedStringException::$xdebug_message
  • PHPStan: 142 unique errors in 8 lanes ⚠️

  • PHP-CS-Fixer: 68 files checked, no issues ✅

❌ Failed Lanes

php8.1-dev

  • PHPUnit: ❌ Setup failed (No result file found)
  • PHPStan: ❌ Setup failed (No result file found)

php8.1-stable

  • PHPUnit: ❌ Setup failed (No result file found)
  • PHPStan: ❌ Setup failed (No result file found)

php8.2-dev

  • PHPStan: 151 errors found

php8.2-stable

  • PHPStan: 151 errors found

php8.3-dev

  • PHPUnit: 0 failures, 1 error
  • PHPStan: 151 errors found

php8.3-stable

  • PHPUnit: 0 failures, 1 error
  • PHPStan: 151 errors found

php8.4-dev

  • PHPStan: 151 errors found

php8.4-stable

  • PHPStan: 151 errors found

php8.5-dev

  • PHPStan: 151 errors found

php8.5-stable

  • PHPStan: 151 errors found

CI powered by horde-componentsView full results

@ralflang ralflang merged commit 9e0d5ff into FRAMEWORK_6_0 Jul 11, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant