Skip to content

Remove unused doctrine/annotations dependency, dropping PHP <8.3 support #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janlam7 merged 2 commits into from
Jun 10, 2026
Merged

Remove unused doctrine/annotations dependency, dropping PHP <8.3 support #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
048812b
Remove unused doctrine/annotations dependency
janlam7 Jun 10, 2026
f4e0b26
Drop PHP <8.3 support
janlam7 Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
php-versions: ['8.1', '8.2', '8.3']
php-versions: ['8.3','8.4']
name: PHP ${{ matrix.php-versions }}
steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 1 addition & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
"description": "Installer for all the Hostnet Doctrine entity libraries",
"license": "MIT",
"require": {
"php": "^8.1",
"php": "^8.3",
"composer-plugin-api": "^2.0.0",
"doctrine/annotations": "^1.13.2",
"phpdocumentor/type-resolver": "^1.4.0",
"symfony/filesystem": "^5.4||^6.0",
"twig/twig": "^3.0"
Expand Down
6 changes: 3 additions & 3 deletions src/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
*/
class Installer extends LibraryInstaller implements PackagePathResolverInterface
{
private const PACKAGE_TYPE = 'hostnet-entity';
private const EXTRA_ENTITY_BUNDLE_DIR = 'entity-bundle-dir';
public const GENERATE_INTERFACES = 'generate-interfaces';
private const string PACKAGE_TYPE = 'hostnet-entity';
private const string EXTRA_ENTITY_BUNDLE_DIR = 'entity-bundle-dir';
public const string GENERATE_INTERFACES = 'generate-interfaces';

private $compound_generators;

Expand Down
4 changes: 2 additions & 2 deletions src/PackageContent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
*/
class PackageContent implements PackageContentInterface
{
public const ENTITY = '\\Entity\\';
public const REPOSITORY = '\\Repository\\';
public const string ENTITY = '\\Entity\\';
public const string REPOSITORY = '\\Repository\\';

private $class_map;
private $type;
Expand Down
2 changes: 1 addition & 1 deletion src/ReflectionTypeInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

interface ReflectionTypeInterface
{
public const NON_QUALIFIED_TYPES = [
public const array NON_QUALIFIED_TYPES = [
'null',
'void',
'self',
Expand Down
2 changes: 1 addition & 1 deletion test/ReflectionParameterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*/
class ReflectionParameterTest extends TestCase
{
private const FOO = 'BAR';
private const string FOO = 'BAR';

private function method($param, \Exception $param_2, array $param_3 = null, $param_4 = \DateTime::ATOM): void
{
Expand Down
Loading