CI Remove empty test reference files#1164
Merged
hsutter merged 2 commits intohsutter:mainfrom Jul 22, 2024
Merged
Conversation
Contributor
Author
|
The test failures will be fixed by #1165. |
fc3af56 to
dfdee88
Compare
dfdee88 to
d9e99c8
Compare
Owner
|
Thanks! |
Contributor
Author
Owner
|
Hmm... one thing I meant to ask before merging this (but forgot, sorry) was: Early on, the reason I was storing files even if empty was because otherwise I couldn't distinguish between "test ran successfully and there was no output" and "test crashed and failed to generate any output." Are we still going to catch the "empty" vs "crashed" case somehow so that we don't start getting silent regressions due to crashes for test cases that would have empty output anyway? |
Contributor
Author
|
That is a good point. The test script currently silently removes the generated empty file. I will add a check that the file actually got created. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run-tests.sh.rm-empty-files.shutility script for removing all empty files in current directory.Note: This PR is one step towards improvements of the kind proposed in #1137. It should make further improvement simpler.
An iterative approach should be easier to handle.