Fix for Add WEBHOOK_JOB to GHEvent#1316
Fix for Add WEBHOOK_JOB to GHEvent#1316bitwiseman merged 5 commits intohub4j:mainfrom katieshin:main
Conversation
| TEAM, | ||
| TEAM_ADD, | ||
| WATCH, | ||
| WEBHOOK_JOB, |
There was a problem hiding this comment.
It's not WEBHOOK_JOB but WORKFLOW_JOB.
There was a problem hiding this comment.
Oh! I'll make the change, thanks.
There was a problem hiding this comment.
Also, my guess is that you will need to change things here: https://github.com/hub4j/github-api/blob/main/src/test/java/org/kohsuke/github/EnumTest.java#L31 .
Always run the tests after a change, especially in a code base you don't know as it's always full of surprises :).
There was a problem hiding this comment.
Thank you for the help!
bitwiseman
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1316 +/- ##
=========================================
Coverage 77.92% 77.92%
Complexity 2016 2016
=========================================
Files 198 198
Lines 6224 6225 +1
Branches 355 355
=========================================
+ Hits 4850 4851 +1
Misses 1164 1164
Partials 210 210
Continue to review full report at Codecov.
|
gsmet
left a comment
gsmet
left a comment
There was a problem hiding this comment.
Maybe this should be squashed into one commit for a cleaner history before merging?
3 participants
Description
Adding fix for #1288 - new enum value for WORKFLOW_JOB in GHEvent.
Fixes #1288
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
main. Create your PR from that branch.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: