Skip to content

fix detach_hook#1880

Merged
SunMarc merged 1 commit into
huggingface:mainfrom
SunMarc:fix_detach_hook
Aug 23, 2023
Merged

fix detach_hook#1880
SunMarc merged 1 commit into
huggingface:mainfrom
SunMarc:fix_detach_hook

Conversation

@SunMarc
Copy link
Copy Markdown
Member

@SunMarc SunMarc commented Aug 23, 2023

What does this PR do ?

Fixes #1869. This PR fixes the detach_hook function from AlignDevicesHook class so that we can call .detach_hook() on a SequentialHook object where one of the hooks is an AlignDevicesHook object.

@SunMarc SunMarc requested a review from sgugger August 23, 2023 17:27
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

【BUG Report】accelerate method remove_hook_from_module can't remove cpu_offload hook.

3 participants