refactor cogvideox pipeline tests to the new mixin structure#14276
Open
akshan-main wants to merge 3 commits into
Open
refactor cogvideox pipeline tests to the new mixin structure#14276akshan-main wants to merge 3 commits into
akshan-main wants to merge 3 commits into
Conversation
Contributor
|
Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
sayakpaul
reviewed
Jul 24, 2026
Comment on lines
148
to
159
| @@ -175,13 +153,9 @@ def test_callback_inputs(self): | |||
| if not (has_callback_tensor_inputs and has_callback_step_end): | |||
| return | |||
|
|
|||
| components = self.get_dummy_components() | |||
| pipe = self.pipeline_class(**components) | |||
| pipe = pipe.to(torch_device) | |||
| pipe.set_progress_bar_config(disable=None) | |||
| self.assertTrue( | |||
| hasattr(pipe, "_callback_tensor_inputs"), | |||
| f" {self.pipeline_class} should have `_callback_tensor_inputs` that defines a list of tensor variables its callback function can use as inputs", | |||
| pipe = self.get_pipeline().to(torch_device) | |||
| assert hasattr(pipe, "_callback_tensor_inputs"), ( | |||
| f" {self.pipeline_class} should have `_callback_tensor_inputs` that defines a list of tensor variables its callback function can use as inputs" | |||
| ) | |||
Member
There was a problem hiding this comment.
Should it not suffice?
Contributor
Author
There was a problem hiding this comment.
Yes, it does. Dropped
github-actions
Bot
added
size/L
6 tasks
sayakpaul
approved these changes
Jul 24, 2026
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the CogVideoX text-to-video pipeline tests to the new mixin structure from #14113:
CogVideoXPipelineTesterConfigplus one test class per mixin, with the integration test moved to a pytest slow class. The old suite had PyramidAttentionBroadcast, FasterCache and FirstBlockCache tests, so those carry over through the new cache mixins.Existing coverage is kept:
test_inference(now asserting a real value slice), thetest_callback_inputsoverride,test_vae_tiling,test_fused_qkv_projections, and the batch-single tolerance override. The attention-slicing override is dropped as the new framework has no equivalent.Before submitting
Who can review?
@sayakpaul