refactor flux2 pipeline tests to the new mixin structure - #14326
Open
akshan-main wants to merge 1 commit into
Open
refactor flux2 pipeline tests to the new mixin structure#14326akshan-main wants to merge 1 commit into
akshan-main wants to merge 1 commit into
Conversation
sayakpaul
reviewed
Jul 30, 2026
| inputs = self.get_dummy_inputs() | ||
| image = pipe(**inputs).images | ||
| original_image_slice = image[0, -3:, -3:, -1] | ||
| original_image_slice = image[0, -1, -3:, -3:] |
Comment on lines
+150
to
152
| assert np.allclose(original_image_slice, image_slice_fused, atol=1e-3, rtol=1e-3), ( | ||
| "Fusion of QKV projections shouldn't affect the outputs." | ||
| ) |
Member
There was a problem hiding this comment.
Shouldn't be using np.allclose().
Contributor
|
Hi @akshan-main, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the Flux2 pipeline tests to the new mixin structure from #14113: a
Flux2PipelineTesterConfigplusTestFlux2Pipeline(PipelineTesterMixin)andTestFlux2PipelineMemory(MemoryTesterMixin), mirroring the flux port.Existing coverage is kept:
test_fused_qkv_projectionsandtest_flux_image_output_shape, with dummy inputs switched tooutput_type="pt"and the slice indexing adjusted for the channels-first layout. No caching tests are added since the old suite had none.Before submitting
Who can review?
@sayakpaul