[docs] Remove attention slicing#4518
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
sayakpaul
approved these changes
Aug 8, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Looks good to me. Should we keep the discarded information somewhere still?
Member
Author
|
Added an example usage in the functions docstring! I think the docstring description still conveys all the discarded information in a more concise way :) |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* remove attention slicing * apply feedback
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* remove attention slicing * apply feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4487 to remove attention slicing section and add a disclaimer to the
enable_attention_slicingfunction because most users use SDPA or xFormers now, and enabling attention slicing with these can cause slowdowns.