Fix #34494 assistant tokens when truncated - #34531
Merged
Rocketknight1 merged 4 commits intoNov 5, 2024
Merged
Conversation
yonigottesman
changed the title
yonigottesman
changed the title
Rocketknight1
approved these changes
Oct 31, 2024
Rocketknight1
left a comment
Rocketknight1
left a comment
Member
There was a problem hiding this comment.
Yes, this makes sense to me now, and the tests are helpful! Thank you!
cc @LysandreJik for core maintainer review
yonigottesman
force-pushed
the
assistant_tokens_truncated
branch
from
November 1, 2024 08:50
73bb879 to
2ccd465
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Nov 5, 2024
LysandreJik
left a comment
LysandreJik
left a comment
Member
There was a problem hiding this comment.
Nice, impressive test! Thanks @yonigottesman
yonigottesman
force-pushed
the
assistant_tokens_truncated
branch
from
November 5, 2024 14:21
f225fdb to
9024b7a
Compare
Contributor
Author
|
rebased and ready for merge... |
Member
|
Merged! |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes a bug that caused #34494.
when using
apply_chat_templatewithreturn_assistant_tokens_maskand token truncation, the assistant mask was not correct.@Rocketknight1