[modular] allow multiple modular files in the same model folder#36287
Open
Cyrilvallez wants to merge 1 commit into
Open
[modular] allow multiple modular files in the same model folder#36287Cyrilvallez wants to merge 1 commit into
Cyrilvallez wants to merge 1 commit into
Conversation
This was referenced Feb 19, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! I don't think we should allow this! Thanks for working on it but it will be a bit against our philO!
Contributor
|
Hi @ArthurZucker! What do you propose to do in this situation then? For example, in case of D-FINE, we created resnet and main models modulars in the same folder like it is done for RT-DETR, but there, resnet is implemented from scratch and we are reusing it in D-FINE implementation that leads to some problems with modular conversion script which @Cyrilvallez is trying to resolve here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. It fixes the issue mentioned in #36261. There are 2 small issues:
rt_detr_resnetandd_fine_resnetboth end withresnet, the prefix matching would lead to inconsistencies