RotaryEmbeddings change is not None -> isinstance(..., dict) - #39145
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qubvel
marked this pull request as ready for review
July 3, 2025 10:57
SwiftAkira
pushed a commit
to SwiftAkira/transformers
that referenced
this pull request
Jul 11, 2025
…gingface#39145) is None -> isinstance dict
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…gingface#39145) is None -> isinstance dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small quality improvement of if/else statement for RotaryEmbeddings, motivated by static typechecking
The behaviour has slightly changed in case
rope_scalinghas an unexpected type:rope_scalingis adictrope_typeretrieved from dictrope_typeretrieved from dictrope_scalingisNonerope_type = "default"rope_type = "default"rope_scalingis an unexpected typeAttributeError: '<type>'object has no attribute 'get'rope_type = "default"cc @gante