fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models - #39830
Merged
qubvel merged 6 commits intoAug 1, 2025
Conversation
…ching for all Keypoint Matching models
qubvel
reviewed
Aug 1, 2025
qubvel
left a comment
qubvel
left a comment
Contributor
There was a problem hiding this comment.
@sbucaille Thanks for making it standardized! Just a few comments
|
|
||
| return results | ||
|
|
||
| def visualize_keypoint_matching( |
| ) -> list[dict[str, torch.Tensor]]: | ||
| return super().post_process_keypoint_matching(outputs, target_sizes, threshold) | ||
|
|
||
| def visualize_keypoint_matching( |
| plt.scatter(keypoint1_x + width0, keypoint1_y, c="black", s=2) | ||
| plt.show() | ||
|
|
||
| def _get_color(self, score): |
|
|
||
| return results | ||
|
|
||
| def visualize_keypoint_matching( |
Comment on lines
+465
to
+475
| def plot_keypoint_matching(self, images: ImageInput, keypoint_matching_output): | ||
| """ | ||
| Plots the image pairs side by side with the detected keypoints as well as the matching between them. Requires | ||
| matplotlib to be installed. | ||
|
|
||
| .. deprecated:: | ||
| `plot_keypoint_matching` is deprecated and will be removed in a future version. Use `visualize_keypoint_matching` instead. | ||
|
|
||
| Args: | ||
| images (`ImageInput`): | ||
| Image pairs to plot. Same as `SuperGlueImageProcessor.preprocess`. Expects either a list of 2 images or |
Contributor
There was a problem hiding this comment.
no need to add this method, it's going to be removed
Contributor
Author
There was a problem hiding this comment.
I went autopilot there, didn't mean to 😅
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: efficientloftr, lightglue, superglue |
qubvel
approved these changes
Aug 1, 2025
qubvel
left a comment
qubvel
left a comment
Contributor
There was a problem hiding this comment.
Thanks, just a nit and ready to be merged!
| - preprocess | ||
| - post_process_keypoint_matching | ||
| - plot_keypoint_matching | ||
| - visualize_keypoint_matching |
Contributor
There was a problem hiding this comment.
let's add the same for superglue
Contributor
Author
There was a problem hiding this comment.
Indeed, forgot about this one, fixed !
qubvel
enabled auto-merge (squash)
August 1, 2025 16:18
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…e_keypoint_matching` as a standard (huggingface#39830) * fix: deprecate plot_keypoint_matching and make visualize_keypoint_matching for all Keypoint Matching models * refactor: added copied from * fix: make style * fix: repo consistency * fix: make style * docs: added missing method in SuperGlue docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
visualize_keypoint_matchingto LightGlue and SuperGlue image processorDeprecate
plot_keypoint_matchingfrom LightGlue image processorWho can review?
@qubvel @stevhliu