Skip to content

Fix an annoying flaky test - #40000

Merged
zucchini-nlp merged 1 commit into
huggingface:mainfrom
zucchini-nlp:flaky-mistral-test
Aug 8, 2025
Merged

Fix an annoying flaky test#40000
zucchini-nlp merged 1 commit into
huggingface:mainfrom
zucchini-nlp:flaky-mistral-test

Conversation

@zucchini-nlp

Copy link
Copy Markdown
Member

What does this PR do?

As per title, trying to download the image from picsum times out if we run the test many times, so I moved the image to HF hub. AFAIK we can make many subsequent requests to hub downloads when testing

@zucchini-nlp
zucchini-nlp requested a review from ydshieh August 7, 2025 14:18
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@vasqu vasqu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also seeing this in #40002 馃檹

@ydshieh

ydshieh commented Aug 7, 2025

Copy link
Copy Markdown
Collaborator

AFAIK we can make many subsequent requests to hub downloads when testing

this is only valid if we are using HF's related methods I believe (something similar to from_pretrained).

When it is in user prompt, do you know what methods are used to download images? (pure python request ..?)

@ydshieh ydshieh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just have a question but we can check later. Thanks

@zucchini-nlp

Copy link
Copy Markdown
Member Author

Ah, then I am not sure if this helps with issues because of too many requests. The chat template script uses simple requests to download the file

@zucchini-nlp

Copy link
Copy Markdown
Member Author

Oke, let's merge and see if it becomes less flaky

@zucchini-nlp
zucchini-nlp merged commit 2469cce into huggingface:main Aug 8, 2025
15 checks passed
@gante

gante commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

PR #40000 馃槺

@ydshieh

ydshieh commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

Congratulation! You should tweet this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants