Skip some csm testcases because of incompatible with torch_comiple - #40267
Closed
yuanwu2017 wants to merge 1 commit into
Closed
Skip some csm testcases because of incompatible with torch_comiple#40267yuanwu2017 wants to merge 1 commit into
yuanwu2017 wants to merge 1 commit into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: csm |
5 tasks
Member
|
cc @ydshieh |
Collaborator
|
Hi @yuanwu2017 These tests are passing in our (Nvidia A10 + torch 2.8.0+cu126) CI runner, as you can see https://github.com/huggingface/transformers/actions/runs/17058159711/job/48359895523 |
Collaborator
|
I see you have
Could you try 2.8.0 or event 2.7.1? Since it is passing in our CI runners, I won't skip them unconditionally, but could do it under some skip conditions. |
Signed-off-by: yuanwu <yuanwu@habana.ai>
Contributor
Author
You are right. Pytorch 2.8 can pass these case. Let me close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip some csm testcases because of CSM output recording incompatible with torch_comiple


Before:
After:
Fixes # (issue 40268)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.