Skip to content

Skip some csm testcases because of incompatible with torch_comiple - #40267

Closed
yuanwu2017 wants to merge 1 commit into
huggingface:mainfrom
yuanwu2017:csm_test
Closed

Skip some csm testcases because of incompatible with torch_comiple#40267
yuanwu2017 wants to merge 1 commit into
huggingface:mainfrom
yuanwu2017:csm_test

Conversation

@yuanwu2017

@yuanwu2017 yuanwu2017 commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Skip some csm testcases because of CSM output recording incompatible with torch_comiple
Before:
image
After:
image

Fixes # (issue 40268)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: csm

@Rocketknight1

Copy link
Copy Markdown
Member

cc @ydshieh

@ydshieh

ydshieh commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

Hi @yuanwu2017

These tests are passing in our (Nvidia A10 + torch 2.8.0+cu126) CI runner, as you can see

https://github.com/huggingface/transformers/actions/runs/17058159711/job/48359895523

@ydshieh

ydshieh commented Aug 19, 2025

Copy link
Copy Markdown
Collaborator

I see you have

2.6.0+cu124 (CUDA)

Could you try 2.8.0 or event 2.7.1?

Since it is passing in our CI runners, I won't skip them unconditionally, but could do it under some skip conditions.

@yuanwu2017

Copy link
Copy Markdown
Contributor Author

I see you have

2.6.0+cu124 (CUDA)

Could you try 2.8.0 or event 2.7.1?

Since it is passing in our CI runners, I won't skip them unconditionally, but could do it under some skip conditions.

You are right. Pytorch 2.8 can pass these case. Let me close it.

@yuanwu2017 yuanwu2017 closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants