Remove stale TODO comments in UDOP tied weights - #43477
Merged
Rocketknight1 merged 1 commit intoJan 26, 2026
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: udop |
Rocketknight1
approved these changes
Jan 26, 2026
Rocketknight1
left a comment
Rocketknight1
left a comment
Member
There was a problem hiding this comment.
Yes, LGTM! (And I'm generally a fan of getting rid of outdated TODOs and open issues because they attract bad code agents)
Rocketknight1
enabled auto-merge (squash)
January 26, 2026 13:26
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
lol yeah that happens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove outdated TODO comments claiming patch embedding weight tying is "not working".
Details
Testing confirms the tying mechanism works correctly:
patch_embed.proj.weightandencoder.embed_patches.proj.weightshare the same tensorThe TODO was added during #41580 refactor but the mechanism works identically to token embedding tying.