[Model] Add SLANeXt Model Support - #43707
Conversation
zucchini-nlp
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR! Could you rebase and update a few moments to align with the latest API?
|
@zucchini-nlp We’ve finished the changes. PTAL. Discussion: However, NumPy-style operations do not seem appropriate for the fast image processor, so we are inclined to think that this model does not need a What do you think? Also, for the sake of code cleanliness and readability, would it be acceptable to use |
Unfortunately we don't have cv2 in dependencies list, so for slow processor we need to stick to numpy. In Fast processor, we can use numpy and torchvision, does |
There was a problem hiding this comment.
I see a few comments not yet resolved, commented there. As for resize, in slow processor we can use PIL and I believe it will work for you case. PIL has all the same resize types as torchvision
Actually we can even delete the slow processor, as fast processor is enough and we're defaulting to load a fast processor anyway. Much easier for you than fixing the code prob
|
@liu-jiaxuan @zhang-prog I pushed my fixes:
|
|
run-slow: slanext |
|
This comment contains models: ["models/slanext"] |
CI ResultsCommit Info
Model CI Report❌ 1 new failed tests from this PR 😭
|
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, slanext |
vasqu
left a comment
There was a problem hiding this comment.
Checked locally with our runners, everything passes now! Merging
Thanks a lot @liu-jiaxuan and @zhang-prog for sticking through
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.