Update latest revision for Phi-4-multimodal test - #45671
Closed
kaixuanliu wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Liu, Kaixuan <kaixuan.liu@intel.com>
4 tasks
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: phi4_multimodal |
kaixuanliu
changed the title
Collaborator
|
This is failing from
I will ping @yonigozlan to see if we can fix in the source code instead. |
Collaborator
|
As discussed offline, we could close this PR as a fix is merged |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a failed test case:
tests/models/phi4_multimodal/test_modeling_phi4_multimodal.py::Phi4MultimodalIntegrationTest::test_audio_text_generation.I submit a PR https://huggingface.co/microsoft/Phi-4-multimodal-instruct/discussions/94 based on https://huggingface.co/microsoft/Phi-4-multimodal-instruct/discussions/70 to avoid usingtrust_remote_codeand fix the bugCommonKwargscannot be found in latest transformers. Hence we need to use 94 revision in the test case. More detailed background pls refer to discussion in #44964. @Cyrilvallez @ydshieh pls help review, thx!