Bump min peft 0.19.1 remove weight conversion duplicate code - #46442
Merged
BenjaminBossan merged 8 commits intoJul 1, 2026
Conversation
As discussed internally. Context When Transformers v5 was released with the new weight conversion feature, it required extra logic to deal with loading PEFT adapters. We agreed to move that logic to PEFT, but at the time there was no PEFT release containing the code, so the logic lived in Transformers. The code has later been duplicated in PEFT and is contained in the 0.19 release (with a bugfix in 0.19.1). Description Now that PEFT v0.19.1 has been out for a long time, we can safely remove the duplicated code in Transformers and bump the min required PEFT version to v0.19.1 (of course, PEFT still is an optional dependency). All duplicated code has been removed and docs have been updated where needed. I have confirmed on my machine that the Transformers PEFT tests still pass with this change. (There are failing tests relating to hotswapping, but those are being worked on elsewhere.) On the other side, PEFT tests for weight conversion also still pass. Open Some PEFT tests use patch_moe_parameter_targeting, but they are correctly guarded against removal of that function. After the next Transformers release, these tests can be removed in PEFT.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
The one failing test, |
ArthurZucker
approved these changes
Jun 9, 2026
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Super nice! I am gonna wait to test if this will break vllm along with https://github.com/huggingface/transformers/pull/46381/changes And will merge once its cool!
(should be alright AFAIK)
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46442&sha=4a6b5b |
Member
Author
|
I merged latest main and resolved the merge conflicts. I ran the PEFT tests locally and they passed, except for the ones that are being worked on in #45682. |
Member
Author
|
@Cyrilvallez Could you please take a look since Arthur mentioned he's busy with tokenizers? I think there should be no blockers for merging (not sure if #46442 (review) is still relevant). |
Cyrilvallez
approved these changes
Jul 1, 2026
BenjaminBossan
enabled auto-merge
July 1, 2026 09:08
Contributor
CI recapDashboard: View test results in Grafana |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 1, 2026
BenjaminBossan
deleted the
bump-min-peft-0.19.1-remove-weight-conversion-duplicate-code
branch
July 1, 2026 16:38
6 tasks
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
…face#46442) * [PEFT] Use PEFT weight conversion code, bump min version to 0.19.1 As discussed internally. Context When Transformers v5 was released with the new weight conversion feature, it required extra logic to deal with loading PEFT adapters. We agreed to move that logic to PEFT, but at the time there was no PEFT release containing the code, so the logic lived in Transformers. The code has later been duplicated in PEFT and is contained in the 0.19 release (with a bugfix in 0.19.1). Description Now that PEFT v0.19.1 has been out for a long time, we can safely remove the duplicated code in Transformers and bump the min required PEFT version to v0.19.1 (of course, PEFT still is an optional dependency). All duplicated code has been removed and docs have been updated where needed. I have confirmed on my machine that the Transformers PEFT tests still pass with this change. (There are failing tests relating to hotswapping, but those are being worked on elsewhere.) On the other side, PEFT tests for weight conversion also still pass. Open Some PEFT tests use patch_moe_parameter_targeting, but they are correctly guarded against removal of that function. After the next Transformers release, these tests can be removed in PEFT. * Fix more instances referring to older PEFT versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed internally.
What does this PR do?
Context
When Transformers v5 was released with the new weight conversion feature, it required extra logic to deal with loading PEFT adapters. We agreed to move that logic to PEFT, but at the time there was no PEFT release containing the code, so the logic lived in Transformers. The code has later been duplicated in PEFT and is contained in the 0.19 release (with a bugfix in 0.19.1).
Description
Now that PEFT v0.19.1 has been out for a long time, we can safely remove the duplicated code in Transformers. All code marked with
# TODO: remove once PEFT < 0.19 no longer supportedis removed. We bump the min required PEFT version to v0.19.1 (of course, PEFT still is an optional dependency).All duplicated code has been removed and docs have been updated where needed. I have confirmed on my machine that the Transformers PEFT tests still pass with this change. (There are failing tests relating to hotswapping, but those are being worked on elsewhere.) On the other side, PEFT tests for weight conversion also still pass.
The failing the CI test seems to be unrelated to this PR.
Open
Some PEFT tests use
patch_moe_parameter_targeting, but they are correctly guarded against removal of that function. After the next Transformers release, these tests can be removed in PEFT.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.