feat[vLLM x v5]: Rename audio_processor to feature_extractor on Granite Speech and Phi-4 Multimodal processors - #46992
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: granite_speech, phi4_multimodal |
CI recapDashboard: View test results in Grafana |
vasqu
left a comment
There was a problem hiding this comment.
Hmm pretty sure we honestly want to switch the other way around at some point but it's a bigger refactor effort, i.e. it takes time. I guess vllm wants to keep consistent naming but you can also nudge to this comment / the discussion resulting for this PR
There was a problem hiding this comment.
FYI here's the PR that @vasqu is referring to: #44394
which will refactor feature extractor to audio processor
not sure what's best, maybe they should be temporarily renamed to feature_extractor as that's the current standard? and the above PR will handle the global library refactor. As I think it will take some time before that PR is merged since it is handling more than just renaming
|
Ok, so it will take a while but I honestly believe it's worse to rename because we drop it either way in the future. Would it be possible to accept both in vllm as we will start deprecating the feature extractor sooner than later and there probaly needs to be some period of adopting |
|
yep I agree with @vasqu. It would be strange for us to have a deprecation warning for |
|
Makes sense, thanks for the clarification @vasqu and @ebezzam, closing the PR. Will point to this discussion and keep both args supported on the vLLM side. Separately, I was wondering if I could bump this audio PR if it'd be of value, whenever you have the time; think it may have gone under the radar last week, thank you! |
|
@harshaljanjani thanks for pointing out the Canary PR! We have been porting several Nemo models to Transformers recently. I'll try to give some feedback by this/next week. |
|
Awesome!! Really appreciate it and thanks for your time :) |
What does this PR do?
→ Fixes vllm-project/vllm#39330 (comment)
→ Renames from
audio_processortofeature_extractor, every other audio-capable processor in the codebase already usesfeature_extractor; these two were the only outliers. Blocker to the vLLM Transformers audio backend PR.→ BC preserved for the deprecation cycle, adapted precedent from the PretrainedConfig.torch_dtype pattern.
→ Version matrix considerations: Users on older Transformers are unaffected; users on new Transformers hitting the legacy
.audio_processorpath see onelogger.warning_onceper session; downstream consumers (including vLLM's own nativegranite_speech.py/phi4mm.py) have untilv5.20to migrate.→ Made sure this doesn't cause any regressions in
tests/models/granite_speech/andtests/models/phi4_multimodal/.cc: @vasqu @eustlb @ebezzam
Code Agent Policy
Before submitting