ci: cover xet as well (runtime error) - #47338
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
6 tasks
vasqu
approved these changes
Jul 15, 2026
vasqu
left a comment
vasqu
left a comment
Collaborator
There was a problem hiding this comment.
Some smaller comments but definitely needed 🤗
Collaborator
Author
|
new peft run with the latest version https://github.com/huggingface/transformers/tree/ci-verify-46766-runtime |
Record every call retried through the read-only cache fallback and report the count (with triggering repo/file ids) in the pytest terminal summary, so CI logs show unambiguously whether the fallback path was exercised.
Collaborator
Author
…er xdist-safe - Wrap huggingface_hub.hf_hub_download (and re-bind already-imported consumers like peft.config) so direct downloads that bypass transformers.cached_files also get the read-only retry. Fixes PEFT adapter_config.json loads against a read-only CI cache. - Record fallback events to a shared per-process directory instead of an in-memory list, so pytest-xdist worker events are aggregated by the controller's terminal summary.
tarekziade
enabled auto-merge
July 15, 2026 16:26
Contributor
CI recapDashboard: View test results in Grafana |
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Jul 30, 2026
* cover xet as well (runtime error) * xet is process-wide and caches locations. the rety now simply disables it * reviews * log read-only cache fallback invocations for CI validation Record every call retried through the read-only cache fallback and report the count (with triggering repo/file ids) in the pytest terminal summary, so CI logs show unambiguously whether the fallback path was exercised. * extend read-only cache fallback to hf_hub_download + make event counter xdist-safe - Wrap huggingface_hub.hf_hub_download (and re-bind already-imported consumers like peft.config) so direct downloads that bypass transformers.cached_files also get the read-only retry. Fixes PEFT adapter_config.json loads against a read-only CI cache. - Record fallback events to a shared per-process directory instead of an in-memory list, so pytest-xdist worker events are aggregated by the controller's terminal summary.
Sainava
pushed a commit
to Sainava/Sai-transformers
that referenced
this pull request
Aug 3, 2026
* cover xet as well (runtime error) * xet is process-wide and caches locations. the rety now simply disables it * reviews * log read-only cache fallback invocations for CI validation Record every call retried through the read-only cache fallback and report the count (with triggering repo/file ids) in the pytest terminal summary, so CI logs show unambiguously whether the fallback path was exercised. * extend read-only cache fallback to hf_hub_download + make event counter xdist-safe - Wrap huggingface_hub.hf_hub_download (and re-bind already-imported consumers like peft.config) so direct downloads that bypass transformers.cached_files also get the read-only retry. Fixes PEFT adapter_config.json loads against a read-only CI cache. - Record fallback events to a shared per-process directory instead of an in-memory list, so pytest-xdist worker events are aggregated by the controller's terminal summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The fallback to use a tempdir on read only cache needs to be extended for XET that produces Runtime errors not OS Errors