Skip to content

trivial: Use lt_current rather than hardcoding the soname directory name#322

Merged
hughsie merged 1 commit into
mainfrom
hughsie/lt_current
Jul 2, 2026
Merged

trivial: Use lt_current rather than hardcoding the soname directory name#322
hughsie merged 1 commit into
mainfrom
hughsie/lt_current

Conversation

@hughsie

@hughsie hughsie commented Jul 2, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Updated installed header and pkg-config locations to use a versioned subdirectory consistently, improving compatibility across library versions.
    • Ensured generated build metadata points to the same version-aware path as installed headers.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 81f4dacd-b02a-4104-8f6e-18736f051baa

📥 Commits

Reviewing files that changed from the base of the PR and between 92c9fbc and 16a037e.

📒 Files selected for processing (1)
  • src/meson.build

📝 Walkthrough

Walkthrough

The build configuration in src/meson.build is updated so header installation directories and pkg-config generated subdirs use a versioned libxmlb-@0@ path formatted with lt_current, replacing the previously fixed libxmlb-2 path.

Changes

Build Subdirectory Versioning

Layer / File(s) Summary
Versioned install and pkg-config paths
src/meson.build
Header install subdirectories and pkg-config `subdirs` are changed from a fixed `libxmlb-2` path to a versioned `libxmlb-@0@` path formatted with `lt_current`.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to use lt_current for versioned soname directory paths instead of hardcoding libxmlb-2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hughsie
hughsie merged commit 16bc869 into main Jul 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant