Fix building the silo when shared-mime-info is installed#327
Open
hughsie wants to merge 1 commit into
Open
Conversation
shared-mime-info 2.5.1 added a `application/x-freedesktop-appstream-component` that is a subclass of `application/xml` -- which breaks the explicit content type checks in the source builder. Abort the loop for any XML subclass instead to cover both cases. Fixes: #325
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe builder source now recognises XML-derived content types, including AppStream MIME types, when determining whether a stream is ready for XML parsing. ChangesXML content detection
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shared-mime-info 2.5.1 added a
application/x-freedesktop-appstream-componentthat is a subclass ofapplication/xml-- which breaks the explicit content type checks in the source builder. Abort the loop for any XML subclass instead to cover both cases.Fixes: #325
Summary by CodeRabbit
application/xmlare handled correctly.text/xmland compressed XML processing.