Skip to content

[SDK][Python] Align python sdk implementation with ts - #3380

Merged
portuu3 merged 3 commits into
developfrom
feat/sdk/python-refactor
Jun 18, 2025
Merged

[SDK][Python] Align python sdk implementation with ts#3380
portuu3 merged 3 commits into
developfrom
feat/sdk/python-refactor

Conversation

@flopez7

@flopez7 flopez7 commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Issue tracking

#3204

Context behind the change

  • Refactor Python SDK to use same structure as Typescript one
  • Created a new decorator to verify signers on methods that really need it
  • Removed handle_transaction and use directly transact on each method
  • Created new handle_error to show proper error messages
  • Refactor all tests to match the new SDK changes

How has this been tested?

  • Ran methods locally using scripts
  • Ran unit tests

Release plan

Deploy new python version

Potential risks; What to monitor; Rollback plan

Check if python SDK is working properly

- Created a new decorator to verify signers on methods that really need it
- Removed handle_transaction and use directly transact on each method
- Created new handle_error to show proper error messages
- Refactor all tests to match the new SDK changes
@vercel

vercel Bot commented Jun 4, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
human-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 10:46am
human-dashboard-frontend 🛑 Canceled (Inspect) Jun 16, 2025 10:46am
staking-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 10:46am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
faucet-frontend ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 10:46am
faucet-server ⬜️ Ignored (Inspect) Visit Preview Jun 16, 2025 10:46am

@portuu3 portuu3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate docs and test all functions

Comment thread packages/sdk/python/human-protocol-sdk/example.py

@Dzeranov Dzeranov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
lets wait for @portuu3 's approval.

@portuu3
portuu3 merged commit 46a311f into develop Jun 18, 2025
@portuu3
portuu3 deleted the feat/sdk/python-refactor branch June 18, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants